...
- Do at least two non-committer reviewers approve?
- Do at least two committer reviewers approve?
- Are there any outstanding reviews that reject the pull request? Do these reviews have critical
comments that warrant blocking it? - Does the PR have a successful CI build?
- Does the PR address all Sonarqube findings or appropriately suppress them?
- Does the PR have a comment regarding the hero status?
- Did you leave a comment about why any of the above was ignored or skipped?
- Did the right documentation get added or updated (or removed)?
- Do these changes need to be highlighted on the Release Notes? (see Release Note Guidelines)
- Does the commit message have the Ticket number prepended? (DDF-####)
- Does the commit message explain what & why? Git Commit Message Guidelines
...